From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30335 invoked by alias); 28 Jul 2011 15:21:15 -0000 Received: (qmail 30323 invoked by uid 22791); 28 Jul 2011 15:21:14 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jul 2011 15:20:55 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6SFKOQo019636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Jul 2011 11:20:24 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6SFKOcL002202; Thu, 28 Jul 2011 11:20:24 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6SFKLa4007640; Thu, 28 Jul 2011 11:20:22 -0400 From: Tom Tromey To: iam ahal Cc: gdb-patches@sourceware.org, eliz@gnu.org, pmuldoon@redhat.com, brobecker@adacore.com, pedro@codesourcery.com, drow@false.org Subject: Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename) References: <20110627160029.GF20676@adacore.com> <834o33qlm9.fsf@gnu.org> <83bowq6x7f.fsf@gnu.org> Date: Thu, 28 Jul 2011 15:57:00 -0000 In-Reply-To: (Tom Tromey's message of "Thu, 28 Jul 2011 09:17:23 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00788.txt.bz2 iam> - ui_out_field_string (uiout, "file", sal.symtab->filename); iam> + ui_out_field_string (uiout, "file", display_filename); Tom> I'm surprised this change has any effect. Tom> I thought the compilation directory and the source file name were kept Tom> separate in the symtab. What is actually happening? Ah, ok -- you are using the absolute file name when compiling. That seems weird to me, but I understand now. I think instead of 'strstr' as a test, you want strncmp, followed by a check to make sure that either the compilation directory ends with a directory separator, or the following character in the source file name is one. Tom