From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-104125-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1709 invoked by alias); 7 Aug 2013 21:03:20 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 1694 invoked by uid 89); 7 Aug 2013 21:03:20 -0000
X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1
Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 07 Aug 2013 21:03:20 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r77L3CV1009470	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 7 Aug 2013 17:03:12 -0400
Received: from psique ([10.3.113.15])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r77L39m2007949	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 7 Aug 2013 17:03:10 -0400
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Doug Evans <dje@google.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH 4/7] AVR support
References: <1374869594-16965-1-git-send-email-sergiodj@redhat.com>	<1374869594-16965-5-git-send-email-sergiodj@redhat.com>	<CADPb22Q9-AaJ=WFK4qXaQdzEFQ3_EHfngLJaWZ8C9Cue=yptyA@mail.gmail.com>
X-URL: http://www.redhat.com
Date: Wed, 07 Aug 2013 21:03:00 -0000
In-Reply-To: <CADPb22Q9-AaJ=WFK4qXaQdzEFQ3_EHfngLJaWZ8C9Cue=yptyA@mail.gmail.com>	(Doug Evans's message of "Sat, 27 Jul 2013 10:10:47 -0700")
Message-ID: <m38v0d1aer.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-08/txt/msg00219.txt.bz2

On Saturday, July 27 2013, Doug Evans wrote:

> Hi.  Just a nit.
>
> On Fri, Jul 26, 2013 at 1:13 PM, Sergio Durigan Junior
> <sergiodj@redhat.com> wrote:
>> Support for the AVR architecture.  More of the same.  Defining an enum
>> containing the differences between Linux kernel generic and AVR signals,
>> and treat them on avr_linux_gdb_signal_{to,from}_target.  In this case,
>> the only difference is the SIGRTMAX.
>>
>> 2013-07-26  Sergio Durigan Junior  <sergiodj@redhat.com>
>>
>>         * avr-tdep.c: Define enum with differences between Linux kernel
>>         and AVR signals.
>>         (avr_linux_gdb_signal_from_target): New function.
>>         (avr_linux_gdb_signal_to_target): Likewise.
>>         (avr_gdbarch_init): Set gdbarch_gdb_signal_{to,from}_target to
>>         the functions mentioned above.
>> [...]
>> +  /* GDB_SIGNAL_REALTIME_33 to _63 are continuous.
>> +
>
> Nit: Either delete this blank line or move it to after the comment.

Fixed, thanks.

-- 
Sergio