From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39547 invoked by alias); 18 Sep 2015 04:31:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39536 invoked by uid 89); 18 Sep 2015 04:31:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f45.google.com Received: from mail-pa0-f45.google.com (HELO mail-pa0-f45.google.com) (209.85.220.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 18 Sep 2015 04:31:53 +0000 Received: by pacfv12 with SMTP id fv12so39694636pac.2 for ; Thu, 17 Sep 2015 21:31:51 -0700 (PDT) X-Received: by 10.66.164.230 with SMTP id yt6mr4653334pab.149.1442550711254; Thu, 17 Sep 2015 21:31:51 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id ql5sm6206015pac.46.2015.09.17.21.31.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Sep 2015 21:31:50 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: Sandra Loosemore , gdb-patches Subject: Re: [patch, testsuite] require readline for gdb.linespec/explicit.exp tab-completion tests References: <55FA6B97.4080209@codesourcery.com> <55FB0B6C.6010401@redhat.com> Date: Fri, 18 Sep 2015 04:31:00 -0000 In-Reply-To: <55FB0B6C.6010401@redhat.com> (Keith Seitz's message of "Thu, 17 Sep 2015 11:50:20 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00435.txt.bz2 Keith Seitz writes: > On 09/17/2015 12:28 AM, Sandra Loosemore wrote: >> Tab-completion tests require readline support. The ones in >> gdb.base/completion.exp are already conditional, but the recently-added >> gdb.linespec/explicit.exp tests are not. This patch fixes that, and >> also an obvious typo ("faill" -> "fail"). The patch is kind of long >> because I had to insert an "if" block and reindent, but there's nothing >> else going on here. OK to commit? > > I'm not a maintainer, but I wouldn't hesitate to commit this as obvious. > Thank you for catching (and fixing) that. Agreed.