From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18436 invoked by alias); 15 Oct 2003 15:25:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18411 invoked from network); 15 Oct 2003 15:25:07 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 15 Oct 2003 15:25:07 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9FFP7M08982 for ; Wed, 15 Oct 2003 11:25:07 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9FFP6r11134; Wed, 15 Oct 2003 11:25:06 -0400 Received: from localhost.localdomain.redhat.com (vpn50-21.rdu.redhat.com [172.16.50.21]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h9FFOdwC018737; Wed, 15 Oct 2003 11:24:51 -0400 To: Elena Zannoni Cc: gdb-patches@sources.redhat.com, rearnsha@arm.com Subject: Re: [PATCH/RFC] coffread.c: delete param References: <16268.28727.18741.65995@localhost.redhat.com> From: Nick Clifton Date: Wed, 15 Oct 2003 15:25:00 -0000 In-Reply-To: <16268.28727.18741.65995@localhost.redhat.com> (Elena Zannoni's message of "Tue, 14 Oct 2003 17:52:55 -0400") Message-ID: User-Agent: Gnus/5.1001 (Gnus v5.10.1) Emacs/21.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg00488.txt.bz2 Hi Elena, > Based on the discussion in this thread: > http://sources.redhat.com/ml/gdb-patches/2003-10/msg00405.html > > I don't have a set up to test this, though. It does build, that's > all I can say. Given Andrew's comment in the code, I would be rather wary of this patch. Presumably there is some good reason for passing the cs->c_sclass field in the (void *) pointer argument slot, or otherwise Andrew would not have gone to all that trouble of casting it. > - > - /* FIXME: cagney/2001-02-01: The nasty (int) -> (long) > - -> (void*) cast is to ensure that that the value of > - cs->c_sclass can be correctly stored in a void > - pointer in MSYMBOL_INFO. Better solutions > - welcome. */ > - gdb_assert (sizeof (void *) >= sizeof (cs->c_sclass)); > msym = prim_record_minimal_symbol_and_info > - (cs->c_name, tmpaddr, ms_type, (void *) (long) cs->c_sclass, > + (cs->c_name, tmpaddr, ms_type, NULL, > sec, NULL, objfile); > [Richard, Nick, this does affect arm-coff] Does it improve things ? :-) If so, what ? Cheers Nick