From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18031 invoked by alias); 18 Dec 2003 17:54:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17784 invoked from network); 18 Dec 2003 17:54:42 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 18 Dec 2003 17:54:42 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hBIHsgA07682; Thu, 18 Dec 2003 12:54:42 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hBIHsfE16824; Thu, 18 Dec 2003 12:54:41 -0500 Received: from localhost.localdomain.redhat.com (vpn50-2.rdu.redhat.com [172.16.50.2]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id hBIHsHkN010129; Thu, 18 Dec 2003 17:54:27 GMT To: Kazuhiro Inaoka Cc: binutils@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH] New port m32r-linux target. References: <007901c3c55c$cc9229e0$2569910a@tool.maec.co.jp> From: Nick Clifton Date: Thu, 18 Dec 2003 17:54:00 -0000 In-Reply-To: <007901c3c55c$cc9229e0$2569910a@tool.maec.co.jp> (Kazuhiro Inaoka's message of "Thu, 18 Dec 2003 20:48:03 +0900") Message-ID: User-Agent: Gnus/5.1001 (Gnus v5.10.1) Emacs/21.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-12/txt/msg00434.txt.bz2 Hi Kazuhiro, > This patch is .. > Support PIC and m32r-linux target. I am sorry, but this patch is not quite ready for committing. There are a couple of small problems with it: * What is the purpose of the USE_M32R_OLD_RELOC define ? It appears to be tested at several places in the code, but it is never set anywhere. * The patch introduces 6 new failures in the GAS testsuite, (m32r/allinsn, m32r/high-1, m32r/relax-1, m32r/uppercase, m32r/m32rx and vtable/entry0). These must be fixed. * It should update guess_is_rela() in binutils/readelf.c to default to RELA type relocations for the M32R. * The gas/NEWS and ld/NEWS files should be updated to mention the support for the new m32r-linux target. * The patch appears to introduce little-endian versions of the m32r target vectors, but you did not mention this in your covering email. Is this new feature intentional ? If so, it ought to be explicitly covered in the relevant ChangeLog entries and also mentioned in the NEWS files as well. Cheers Nick