From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15437 invoked by alias); 17 Jul 2008 23:41:18 -0000 Received: (qmail 15427 invoked by uid 22791); 17 Jul 2008 23:41:17 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Jul 2008 23:40:50 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m6HNemIh024036 for ; Thu, 17 Jul 2008 19:40:48 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m6HNemLT031172; Thu, 17 Jul 2008 19:40:48 -0400 Received: from opsy.redhat.com (vpn-10-17.bos.redhat.com [10.16.10.17]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m6HNelOJ001138; Thu, 17 Jul 2008 19:40:48 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id C767D5086F9; Thu, 17 Jul 2008 17:40:46 -0600 (MDT) To: Joel Brobecker Cc: vladimir@codesourcery.com, gdb-patches@sources.redhat.com Subject: Re: RFA: Remove gdb-events References: <20080714171004.GC3998@adacore.com> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Thu, 17 Jul 2008 23:41:00 -0000 In-Reply-To: <20080714171004.GC3998@adacore.com> (Joel Brobecker's message of "Mon\, 14 Jul 2008 10\:10\:04 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00357.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> Eli: if you could take a look at the documentation of the new Joel> observers, that would be great! I'm going to approve the Joel> technical part, and we'll follow any suggestion you might have Joel> either before or after commit. Joel> Vladimir: This patch touches MI. Could you take a look at this part Joel> of the patch? The changes seem fine to me, but see below my suggestion. I'm waiting for these two, so I haven't sent an updated patch. But... Joel> First nit: gdbarch.c is a generated file. You'll need to modify Joel> gdbarch.sh instead, and regenerate gdbarch.c. You'll see that Joel> the changes should be identical to the ones you made, but in a Joel> different file. Thanks, I fixed this. >> +++ Makefile.in 13 Jul 2008 00:04:57 -0000 Joel> For this part, could you re-do a pass to check that the dependencies Joel> have all been correctly updated. For instance, I noticed that for Joel> tracepoint.c, you correctly removed the dependency on gdb-events.h, Joel> but forgot to add the one on observer.h. As far as I can tell, this Joel> is the only case were something was missed. I checked and all the dependencies are there, afaict. I think you just misread the tracepoint.o hunk. See the second insertion: @@ -2933,9 +2930,9 @@ tracepoint.o: tracepoint.c $(defs_h) $(symtab_h) $(frame_h) $(gdbtypes_h) \ $(expression_h) $(gdbcmd_h) $(value_h) $(target_h) $(language_h) \ $(gdb_string_h) $(inferior_h) $(tracepoint_h) $(remote_h) \ - $(linespec_h) $(regcache_h) $(completer_h) $(gdb_events_h) \ + $(linespec_h) $(regcache_h) $(completer_h) \ $(block_h) $(dictionary_h) $(ax_h) $(ax_gdb_h) $(readline_h) \ - $(readline_history_h) + $(readline_history_h) $(observer_h) trad-frame.o: trad-frame.c $(defs_h) $(frame_h) $(trad_frame_h) \ $(regcache_h) $(frame_unwind_h) $(value_h) tramp-frame.o: tramp-frame.c $(defs_h) $(tramp_frame_h) $(frame_unwind_h) \ thanks, Tom