From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5180 invoked by alias); 22 Nov 2008 17:49:42 -0000 Received: (qmail 5090 invoked by uid 22791); 22 Nov 2008 17:49:41 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 22 Nov 2008 17:49:06 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAMHmi8l007074; Sat, 22 Nov 2008 12:48:44 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAMHmgSa002080; Sat, 22 Nov 2008 12:48:43 -0500 Received: from opsy.redhat.com (vpn-12-17.rdu.redhat.com [10.11.12.17]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mAMHmfjQ024116; Sat, 22 Nov 2008 12:48:42 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 24F6B378BCD; Sat, 22 Nov 2008 10:48:40 -0700 (MST) To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: RFA: fix address in call to val_print References: <20081122051123.GC4318@adacore.com> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Sun, 23 Nov 2008 21:15:00 -0000 In-Reply-To: <20081122051123.GC4318@adacore.com> (Joel Brobecker's message of "Fri\, 21 Nov 2008 21\:11\:24 -0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00612.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> * valprint.c (val_print_array_elements): Pass correct >> element address to val_print. Joel> I'm wondering about the testcase. As I understand it, it wouldn't cause Joel> any problem with the current FSF version of GDB. But if it's easy to Joel> create one, then I think it'd still be a useful test to have, just to Joel> make sure it doesn't regress in the future. Ok, I will hold off on this patch until I can make a test case. Tom