From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] valprint.c (read_string): Rework clean-up logic.
Date: Fri, 27 Feb 2009 19:56:00 -0000 [thread overview]
Message-ID: <m37i3b676v.fsf@fleche.redhat.com> (raw)
In-Reply-To: <49A82F5C.9000801@redhat.com> (Phil Muldoon's message of "Fri\, 27 Feb 2009 18\:22\:20 +0000")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> 2009-02-27 Phil Muldoon <pmuldoon@redhat.com>
Phil> * valprint.c (xfree_gdb_byte): New function.
Phil> (read_string): Rework clean-up logic. Use xfree_gdb_byte for
Phil> clean-up.
This is almost ok...
Phil> +/* Local clean-up for a gdb_byte buffer pointed to via double
Phil> + indirection. This function is used in read_string. */
Phil> +static void
Phil> +xfree_gdb_byte (void *buffer)
I forgot that there is already a function for this --
free_current_contents. So, this new function is not needed...
Phil> + old_chain = make_cleanup (xfree_gdb_byte, buffer);
... and you can just s/xfree_gdb_byte/free_current_contents/ here.
It is ok with that change. Thanks.
Tom
next prev parent reply other threads:[~2009-02-27 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 19:41 Phil Muldoon
2009-02-27 19:56 ` Tom Tromey [this message]
2009-02-27 22:11 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37i3b676v.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox