From: Tom Tromey <tromey@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org, archer@sourceware.org
Subject: Re: [patch] fix for crash in python pretty-printer
Date: Tue, 07 Jul 2009 20:54:00 -0000 [thread overview]
Message-ID: <m37hykp62f.fsf@fleche.redhat.com> (raw)
In-Reply-To: <8ac60eac0907071341m71bff75by3b7c958e86bbcd39@mail.gmail.com> (Paul Pluzhnikov's message of "Tue\, 7 Jul 2009 13\:41\:21 -0700")
>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
Paul> It turns out I didn't follow what happens when value_struct_elt() raises
Paul> error correctly: when it does, res_val will be left as NULL, and that will
Paul> trigger gdb_assert in my previous patch.
I missed that too.
Paul> Here is a fix. Sorry for the noise :-(
No big deal. This is ok if you haven't committed it already.
Paul> if (field)
Paul> xfree (field);
Jim Meyering has been going around removing these redundant 'if's.
This is something I'm *sure* coccinelle can do :-)
BTW, I neglected to mention upthread -- Taras has got dehydra and
treehydra working for C. So, you could probably write a TRY_CATCH
checker in javascript without too much trouble.
Tom
next prev parent reply other threads:[~2009-07-07 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 18:01 Paul Pluzhnikov
2009-07-07 18:23 ` Tom Tromey
2009-07-07 19:51 ` Paul Pluzhnikov
2009-07-07 20:41 ` Paul Pluzhnikov
2009-07-07 20:54 ` Tom Tromey [this message]
2009-07-07 21:05 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37hykp62f.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=archer@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox