From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17367 invoked by alias); 16 Oct 2009 18:07:20 -0000 Received: (qmail 17358 invoked by uid 22791); 16 Oct 2009 18:07:19 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Oct 2009 18:07:13 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9GI74PO018832; Fri, 16 Oct 2009 14:07:04 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9GI73QP009509; Fri, 16 Oct 2009 14:07:03 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n9GI72oP028965; Fri, 16 Oct 2009 14:07:03 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 5F13E37820F; Fri, 16 Oct 2009 12:07:02 -0600 (MDT) From: Tom Tromey To: Eli Zaretskii Cc: Phil Muldoon , gdb-patches@sourceware.org Subject: Re: [patch][doc] PR python/10781 References: <4AD82247.3070503@redhat.com> <838wfbixtf.fsf@gnu.org> Reply-To: tromey@redhat.com Date: Fri, 16 Oct 2009 18:07:00 -0000 In-Reply-To: <838wfbixtf.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 16 Oct 2009 09:48:28 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00368.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: >> +Cast the @code{gdb.Value} to the type represented by @var{type}, and Eli> ^^^ Eli> Please remove this "the". Removing the "the" makes this read strangely. gdb.Value is a class, the "the" indicates that it is an instance which is cast. >> +return a new @code{gdb.Value}. @var{type} must be a @code{gdb.Type} >> +object. Eli> If TYPE is an object, then it probably isn't a good idea to call it Eli> TYPE. Why not OBJECT? I think it is generally preferable to name parameters according to their use. "object" is not specific enough. Eli> Anyway, what does it mean "the type represented by TYPE"? How can a Eli> type be "represented"? Did you perhaps mean "the type of TYPE"? gdb.Type represents a type in the inferior. "the type of TYPE" would be incorrect. Tom