From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68125-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30243 invoked by alias); 2 Nov 2009 19:44:10 -0000
Received: (qmail 30234 invoked by uid 22791); 2 Nov 2009 19:44:09 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Nov 2009 19:44:05 +0000
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA2Ji4bt003853 	for <gdb-patches@sourceware.org>; Mon, 2 Nov 2009 14:44:04 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA2Ji3FH018967; 	Mon, 2 Nov 2009 14:44:04 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nA2Jhr5c006084; 	Mon, 2 Nov 2009 14:44:00 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 547EC3785E8; Mon,  2 Nov 2009 12:43:53 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: RFC: Simplify partial dies
References: <20091102152607.GA10051@caradoc.them.org>
Reply-To: tromey@redhat.com
Date: Mon, 02 Nov 2009 19:44:00 -0000
In-Reply-To: <20091102152607.GA10051@caradoc.them.org> (Daniel Jacobowitz's 	message of "Mon, 2 Nov 2009 10:26:07 -0500")
Message-ID: <m37hu8g1af.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00032.txt.bz2

>>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:

Daniel> -  if (comp_unit_die.dirname)
Daniel> -    pst->dirname = obsavestring (comp_unit_die.dirname,
Daniel> -				 strlen (comp_unit_die.dirname),
Daniel> +  attr = dwarf2_attr (comp_unit_die, DW_AT_comp_dir, &cu);
Daniel> +  if (attr != NULL)
Daniel> +    pst->dirname = obsavestring (DW_STRING (attr),
Daniel> +				 strlen (DW_STRING (attr)),
Daniel>  				 &objfile->objfile_obstack);
 
Is this obsavestring actually needed?  I thought a DW_STRING value
necessarily had to live as long as the symbol tables, so did not need to
be copied; but if that isn't so, I would like to know.

Tom