From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18602 invoked by alias); 18 Dec 2009 20:47:50 -0000 Received: (qmail 18593 invoked by uid 22791); 18 Dec 2009 20:47:49 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Dec 2009 20:47:43 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBIKlZil029494 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 18 Dec 2009 15:47:36 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBIKlZsg021310; Fri, 18 Dec 2009 15:47:35 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nBIKlYP2028727; Fri, 18 Dec 2009 15:47:34 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 88C7E3782A0; Fri, 18 Dec 2009 13:47:33 -0700 (MST) From: Tom Tromey To: Stan Shebs Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Trace state variables References: <4B279456.1010508@codesourcery.com> <4B2BE005.4090004@codesourcery.com> Reply-To: tromey@redhat.com Date: Fri, 18 Dec 2009 20:47:00 -0000 In-Reply-To: <4B2BE005.4090004@codesourcery.com> (Stan Shebs's message of "Fri, 18 Dec 2009 12:03:17 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00269.txt.bz2 >>>>> "Stan" == Stan Shebs writes: Stan> + case BINOP_ASSIGN: >> It seems a little odd to add BINOP_ASSIGN but not BINOP_ASSIGN_MODIFY. Stan> You're going to make me do it, aren't you. :-) :-) It is really up to you, I won't insist on it. I don't think it is much code, though... Stan> extern int remote_supports_cond_tracepoints (void); Stan> + extern char *unpack_varlen_hex (char *buff, ULONGEST *result); >> It seems like this could be in a header somewhere. Stan> This is one of the temporary hacks pending target-vectorization of Stan> tracepoint ops. Aha, thanks. Tom