From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13160 invoked by alias); 24 Feb 2010 17:22:17 -0000 Received: (qmail 13143 invoked by uid 22791); 24 Feb 2010 17:22:15 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Feb 2010 17:22:11 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1OHM8X2016208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Feb 2010 12:22:08 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1OHM7Zp024138; Wed, 24 Feb 2010 12:22:07 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o1OHM6mN015665; Wed, 24 Feb 2010 12:22:06 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 1B38A37818E; Wed, 24 Feb 2010 10:22:06 -0700 (MST) From: Tom Tromey To: Phil Muldoon Cc: Eli Zaretskii , gdb-patches ml Subject: Re: [patch][python] Add symbol, symbol table and frame block support to GDB API References: <4B66DA35.7080701@redhat.com> <4B796506.7010909@redhat.com> <20100219141457.GB2602@localhost.localdomain> <20100224165709.GA31513@localhost.localdomain> Reply-To: tromey@redhat.com Date: Wed, 24 Feb 2010 17:22:00 -0000 In-Reply-To: <20100224165709.GA31513@localhost.localdomain> (Phil Muldoon's message of "Wed, 24 Feb 2010 16:57:09 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00602.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Tom> Yes, I think we should change it so that "print foo" or "str(foo)" Tom> yields the "most natural" name. Phil> Fixed here and other places regarding _str returns. One last fix... Phil> +static PyObject * Phil> +sympy_str (PyObject *self) Phil> +{ This function is the same as sympy_get_print_name. So, remove the latter and just make both methods point to the same implementation. (IMO it is fine to have an explicit method doing the same thing as str). Ok with this change. Thanks. Tom