From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16351 invoked by alias); 30 Mar 2010 15:57:39 -0000 Received: (qmail 16305 invoked by uid 22791); 30 Mar 2010 15:57:37 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Mar 2010 15:57:34 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2UFvWHl025948 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 30 Mar 2010 11:57:32 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2UFvW6t014743; Tue, 30 Mar 2010 11:57:32 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2UFvTBQ007303; Tue, 30 Mar 2010 11:57:30 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id DF9D5378185; Tue, 30 Mar 2010 09:57:28 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix crash on NULL rl_prompt References: <20100329234026.GA23895@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Tue, 30 Mar 2010 15:57:00 -0000 In-Reply-To: <20100329234026.GA23895@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue, 30 Mar 2010 01:40:26 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg01050.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> BTW don't you think xstrdup (NULL) should == NULL? Like xmalloc Jan> (0) == NULL. I personally don't care either way. If you want to do it, that is fine by me. Jan> 2010-03-30 Jan Kratochvil Jan> * tui/tui-io.c (tui_prep_terminal): Permit NULL rl_prompt. Ok. Tom