From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26841 invoked by alias); 15 Jun 2010 15:54:45 -0000 Received: (qmail 26821 invoked by uid 22791); 15 Jun 2010 15:54:43 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jun 2010 15:54:37 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5FFsY9C027570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 15 Jun 2010 11:54:34 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5FFsXUK014369; Tue, 15 Jun 2010 11:54:33 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o5FFsWH7028419; Tue, 15 Jun 2010 11:54:32 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 474CB379863; Tue, 15 Jun 2010 09:54:32 -0600 (MDT) From: Tom Tromey To: Frederic Riss Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: RFC: optimized-out pieces References: <20100607223524.GA2897@host0.dyn.jankratochvil.net> <20100608184224.GA6814@host0.dyn.jankratochvil.net> <20100609054948.GA5627@host0.dyn.jankratochvil.net> Reply-To: Tom Tromey Date: Tue, 15 Jun 2010 15:54:00 -0000 In-Reply-To: (Frederic Riss's message of "Mon, 14 Jun 2010 14:07:19 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00338.txt.bz2 >>>>> "Frederic" == Frederic Riss writes: Tom> I am checking in the latest version of this patch. Frederic> I think this patch regresses on architectures that mark registers as Frederic> optimized in their CFI. Thanks for the detailed report. It looks like Ulrich already fixed this. I'm sorry about the breakage; I'm looking at setting up a buildbot so we can more easily regression test on multiple architectures. Frederic> I fixed that by preventing frame_register_unwind to call Frederic> value_contents_all in the optimized case (not providing the one-liner Frederic> as I don't have the copyright assignment in place anymore). A short patch like that would not require an assignment. However... why not get a new assignment? It will be fun and rewarding! Tom