From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4132 invoked by alias); 24 May 2011 13:37:18 -0000 Received: (qmail 4072 invoked by uid 22791); 24 May 2011 13:37:17 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 May 2011 13:37:01 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4ODacgg013526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 24 May 2011 09:36:38 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4ODabUo025559; Tue, 24 May 2011 09:36:38 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4ODabfL023052; Tue, 24 May 2011 09:36:37 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 9777D37919A; Tue, 24 May 2011 07:36:36 -0600 (MDT) From: Tom Tromey To: Tristan Gingold Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] aix: add support for dwarf2. References: <1306146544-3925-1-git-send-email-gingold@adacore.com> <1306146544-3925-4-git-send-email-gingold@adacore.com> <5EE240AB-A6C1-4925-92D2-E0C0BCFCC43B@adacore.com> Date: Tue, 24 May 2011 13:37:00 -0000 In-Reply-To: <5EE240AB-A6C1-4925-92D2-E0C0BCFCC43B@adacore.com> (Tristan Gingold's message of "Tue, 24 May 2011 09:20:01 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00563.txt.bz2 >>>>> "Tristan" == Tristan Gingold writes: Tristan> + if (this_symtab_psymtab == NULL) Tristan> + return; Tom> I don't understand this change. Tristan> This is just a guard. process_linenos (called by Tristan> aix_process_linenos) will dereference this_symtab_psymtab, Tristan> which is set by read_xcoff_symtab. However, if the psymtab is Tristan> built by dwarf2, the variable will never be initialized. Tristan> Do you think the issue is somewhere else ? It is very unclear to me whether this can be non-NULL even with DWARF. In the DWARF case wouldn't the line information come from the DWARF line table? In which case it seems like xcoffread.c should have a second struct sym_fns, with a NULL entry for this method. Tom