From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84868-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22668 invoked by alias); 2 Nov 2011 18:30:53 -0000
Received: (qmail 22654 invoked by uid 22791); 2 Nov 2011 18:30:51 -0000
X-SWARE-Spam-Status: No, hits=-7.5 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Nov 2011 18:30:35 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA2IUYi2030371	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 2 Nov 2011 14:30:34 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA2IUYMP009730;	Wed, 2 Nov 2011 14:30:34 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA2IUW5J029463;	Wed, 2 Nov 2011 14:30:33 -0400
From: Tom Tromey <tromey@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: JIT Reader
References: <4EA9095D.5070408@playingwithpointers.com>
Date: Wed, 02 Nov 2011 18:30:00 -0000
In-Reply-To: <4EA9095D.5070408@playingwithpointers.com> (Sanjoy Das's message	of "Thu, 27 Oct 2011 13:03:49 +0530")
Message-ID: <m37h3ixtpz.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00045.txt.bz2

>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:

Sanjoy> +static int
Sanjoy> +jit_reader_try_read_symtab (struct jit_code_entry *code_entry)
[...]
Sanjoy> +  gdb_mem = xmalloc (code_entry->symfile_size);
Sanjoy> +  if (target_read_memory (code_entry->symfile_addr, gdb_mem,
Sanjoy> +                          code_entry->symfile_size))
Sanjoy> +    {
Sanjoy> +      status = 0;
Sanjoy> +      goto cleanup;
Sanjoy> +    }

It is not at all clear to me that target_read_memory cannot throw an
exception.  I think it would be safer to wrap this in a TRY_CATCH.

Tom