From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21992 invoked by alias); 29 Nov 2011 14:56:46 -0000 Received: (qmail 21854 invoked by uid 22791); 29 Nov 2011 14:56:44 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Nov 2011 14:56:31 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pATEuVsS029325 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 29 Nov 2011 09:56:31 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pATEuVmI021119; Tue, 29 Nov 2011 09:56:31 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pATEuTL8018644; Tue, 29 Nov 2011 09:56:30 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: decode_digits_line_mode References: <20111123163917.GA13809@adacore.com> <20111123232406.GQ13809@adacore.com> <20111124105603.GA91879@adacore.com> <20111124163304.GR13809@adacore.com> <20111129031347.GO24943@adacore.com> Date: Tue, 29 Nov 2011 14:56:00 -0000 In-Reply-To: <20111129031347.GO24943@adacore.com> (Joel Brobecker's message of "Mon, 28 Nov 2011 19:13:47 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00813.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> One tiny suggestion: Joel> s/decode_digits_line_mode/decode_digits_list_mode/ Joel> The function documentation talks about 'list_mode', and the call Joel> to that function also checks self->list_mode: Yeah, thanks, I will fix that. I have some mental block about line-vs-list here, and I had to correct the code more than once since I typed the wrong thing. Tom