From: Tom Tromey <tromey@redhat.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: "gdb-patches\@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: RFA: display an error message if libunwind-XX cannot be load
Date: Wed, 01 Feb 2012 15:33:00 -0000 [thread overview]
Message-ID: <m37h06d0xa.fsf@fleche.redhat.com> (raw)
In-Reply-To: <01BDAEC2-6805-4E7B-A0E6-5D728B0158DA@adacore.com> (Tristan Gingold's message of "Wed, 1 Feb 2012 15:06:28 +0100")
>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:
Tristan> * libunwind-frame.c (libunwind_load): Display message if
Tristan> dlopen failed.
Tristan> + fprintf_unfiltered (gdb_stderr, "\
Tristan> +[GDB failed to load %s: %s]\n", LIBUNWIND_SO, dlerror ());
This is missing _().
This is ok with that change.
Do you want to print something for all the other failure cases in that
function?
Tom
next prev parent reply other threads:[~2012-02-01 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 14:06 Tristan Gingold
2012-02-01 15:33 ` Tom Tromey [this message]
2012-02-01 16:24 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37h06d0xa.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox