From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30396 invoked by alias); 8 May 2012 13:53:39 -0000 Received: (qmail 30388 invoked by uid 22791); 8 May 2012 13:53:36 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 May 2012 13:53:22 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q48DrJHO030006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 May 2012 09:53:20 -0400 Received: from psique ([10.3.112.12]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q48DrGcl006143; Tue, 8 May 2012 09:53:18 -0400 From: Sergio Durigan Junior To: Joel Sherrill Cc: gdb-patches@sourceware.org Subject: Re: Microblaze simulator - Fix missing prototype References: <4FA91C76.1090108@oarcorp.com> X-URL: http://www.redhat.com Date: Tue, 08 May 2012 13:53:00 -0000 In-Reply-To: <4FA91C76.1090108@oarcorp.com> (Joel Sherrill's message of "Tue, 8 May 2012 08:15:34 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00223.txt.bz2 On Tuesday, May 08 2012, Joel Sherrill wrote: > Without this patch, the Microblaze simulator generates > a missing prototype warning which is treated as an error. > I don't see this routine referenced elsewhere, so there is > the possibility that it also could be made static. But > it definitely needs a prototype to build. (a) The patch does not reflect the subject of the message, nor the ChangeLog; (b) I have already made comments about the message above in http://sourceware.org/ml/gdb-patches/2012-05/msg00207.html -- Sergio