From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13964 invoked by alias); 6 Dec 2013 17:19:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13895 invoked by uid 89); 6 Dec 2013 17:19:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pb0-f43.google.com Received: from Unknown (HELO mail-pb0-f43.google.com) (209.85.160.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 06 Dec 2013 17:19:28 +0000 Received: by mail-pb0-f43.google.com with SMTP id rq2so1418598pbb.16 for ; Fri, 06 Dec 2013 09:19:20 -0800 (PST) X-Received: by 10.68.163.33 with SMTP id yf1mr5418571pbb.143.1386350360638; Fri, 06 Dec 2013 09:19:20 -0800 (PST) Received: from sspiff.sspiff.org.gmail.com (173-13-178-50-sfba.hfc.comcastbusiness.net. [173.13.178.50]) by mx.google.com with ESMTPSA id b3sm9773593pbu.38.2013.12.06.09.19.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Dec 2013 09:19:19 -0800 (PST) From: Doug Evans To: Phil Muldoon Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v1 03/13] script language API for GDB: python.[ch] changes References: <52a1662d.a601430a.7cf1.61b3@mx.google.com> <52A19C34.3050206@redhat.com> Date: Fri, 06 Dec 2013 17:19:00 -0000 In-Reply-To: <52A19C34.3050206@redhat.com> (Phil Muldoon's message of "Fri, 06 Dec 2013 09:43:16 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00253.txt.bz2 Phil Muldoon writes: > On 06/12/13 05:52, xdje42@gmail.com wrote: >> This patch contains the changes to python-internal.h, python.c, python.h. >> It defines the "ops" vectors for Python, defines script_language_python >> as the top level interface to Python, and then has a bunch of renamings. >> The functions that implement the script_language_ops "methods" are all >> named ${lang}_${method_name}. >> Functions that were exported to gdb now live in the ops vectors. > > Thanks, I am reviewing these today. But, just a quick note. > >> @@ -1815,8 +1851,29 @@ finish_python_initialization (void) >> do_cleanups (cleanup); >> } >> >> +/* Return non-zero if Python has successfully initialized. >> + This is the script_languages_ops.initialized "method". */ >> + >> +static int >> +gdbpy_initialized (const struct script_language_defn *slang) >> +{ >> + return gdb_python_initialized; >> +} >> + >> #endif /* HAVE_PYTHON */ >> >> +/* Some code (e.g., MI) wants to know if a particular scripting language >> + successfully initialized. >> + Return non-zero if Python scripting successfully initialized. */ >> + >> +int >> +script_lang_python_initialized (void) >> +{ >> + if (script_language_python.ops != NULL) >> + return script_language_python.ops->initialized (&script_language_python); >> + return 0; >> +} >> + > > This hunk was rejected via patch. All the other patches and hunks in > all the other mails were fine, so weird. Anyway just thought I would > note it, you might need to do a git pull. Or maybe the ^L's got mangled > by the mailer or something. Blech. These were sent out basically by piping them through ssmtp. And I test-applied all the patches in a clean sandbox before sending. Sorry 'bout that. I'll check and see if I can find something wrong.