From: Doug Evans <xdje42@gmail.com>
To: binutils@sourceware.org
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Include minimal symbol flavour name in LOC_UNRESOLVED error message.
Date: Sat, 29 Aug 2015 23:37:00 -0000 [thread overview]
Message-ID: <m37fodekgz.fsf@sspiff.org> (raw)
In-Reply-To: <m3bndpel90.fsf@sspiff.org> (Doug Evans's message of "Sat, 29 Aug 2015 16:19:07 -0700")
Doug Evans <xdje42@gmail.com> writes:
> Hi.
>
> The error message that is printed if a LOC_UNRESOLVED minsym isn't
> found can be a bit confusing. The goal here is to clarify what the
> term "symbol" means in the error message.
>...
> 2015-08-29 Doug Evans <xdje42@gmail.com>
>
> bfd/
> * targets.c (enum bfd_flavour): Add comment.
> (bfd_flavour_name): New function.
> * bfd-in2.h: Regenerate.
>...
> +const char *
> +bfd_flavour_name (bfd *abfd)
> +{
> + switch (abfd->xvec->flavour)
Btw, a better way to do this would be to take the flavour enum
as the parameter instead of the bfd. Why does the caller
have to have a bfd in order to get the print form of the
enum? I'll do that assuming the patch is otherwise ok.
Callers with a bfd could then just do
bfd_flavour_name (bfd_get_flavour (abfd)).
next prev parent reply other threads:[~2015-08-29 23:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 23:20 Doug Evans
2015-08-29 23:37 ` Doug Evans [this message]
2015-09-03 15:39 ` Nick Clifton
2015-09-19 4:50 ` Doug Evans
2015-09-21 19:21 ` Hans-Peter Nilsson
2015-10-18 20:16 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37fodekgz.fsf@sspiff.org \
--to=xdje42@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox