From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFA: fix locale configure checks
Date: Thu, 21 Aug 2008 20:45:00 -0000 [thread overview]
Message-ID: <m363pujdyh.fsf@fleche.redhat.com> (raw)
Today while exploring the charset code I happened to notice that gdb
never calls setlocale.
The code is there, but configure never does the checks that might
define HAVE_LOCALE_H, HAVE_SETLOCALE, or HAVE_LC_MESSAGES.
This patch fixes the problem. I just copied what GCC does here.
Built & regtested on x86-64. I also examined the config.h on my x86
box by hand.
Ok?
Tom
:ADDPATCH build:
2008-08-21 Tom Tromey <tromey@redhat.com>
* config.in, configure: Rebuild.
* configure.ac: Check for locale.h, setlocale. Call
AM_LC_MESSAGES.
* acinclude.m4: Include lcmessage.m4.
diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4
index 4e8f590..2a951e2 100644
--- a/gdb/acinclude.m4
+++ b/gdb/acinclude.m4
@@ -26,6 +26,9 @@ sinclude(../config/tcl.m4)
dnl For dependency tracking macros.
sinclude([../config/depstand.m4])
+dnl For AM_LC_MESSAGES
+sinclude([../config/lcmessage.m4])
+
#
# Sometimes the native compiler is a bogus stub for gcc or /usr/ucb/cc. This
# makes configure think it's cross compiling. If --target wasn't used, then
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 680fba0..2d2c955 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -647,6 +647,7 @@ AC_CHECK_HEADERS(link.h, [], [],
# include <nlist.h>
#endif
])
+AC_CHECK_HEADERS(locale.h)
AC_CHECK_HEADERS(machine/reg.h)
AC_CHECK_HEADERS(poll.h sys/poll.h)
AC_CHECK_HEADERS(proc_service.h thread_db.h gnu/libc-version.h)
@@ -713,6 +714,7 @@ AC_CHECK_HEADERS(ctype.h time.h)
AC_CHECK_DECLS([free, malloc, realloc])
AC_CHECK_DECLS([strerror, strstr])
AC_CHECK_DECLS([getopt, snprintf, vsnprintf])
+AM_LC_MESSAGES
# ----------------------- #
# Checks for structures. #
@@ -753,6 +755,7 @@ AC_CHECK_FUNCS(poll)
AC_CHECK_FUNCS(pread64)
AC_CHECK_FUNCS(sbrk)
AC_CHECK_FUNCS(setpgid setpgrp setsid)
+AC_CHECK_FUNCS(setlocale)
AC_CHECK_FUNCS(sigaction sigprocmask sigsetmask)
AC_CHECK_FUNCS(socketpair)
AC_CHECK_FUNCS(syscall)
next reply other threads:[~2008-08-21 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 20:45 Tom Tromey [this message]
2008-11-25 23:12 ` Tom Tromey
2008-11-26 3:04 ` Thiago Jung Bauermann
2008-11-26 10:01 ` Tom Tromey
2008-12-09 11:05 ` Joel Brobecker
2008-12-09 17:20 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m363pujdyh.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox