From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8228 invoked by alias); 20 Feb 2009 00:20:25 -0000 Received: (qmail 8219 invoked by uid 22791); 20 Feb 2009 00:20:25 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Feb 2009 00:20:19 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n1K0JF04031221; Thu, 19 Feb 2009 19:19:15 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1K0JF1o027512; Thu, 19 Feb 2009 19:19:15 -0500 Received: from opsy.redhat.com (vpn-12-33.rdu.redhat.com [10.11.12.33]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n1K0JD1I002508; Thu, 19 Feb 2009 19:19:14 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 1BB675080FB; Thu, 19 Feb 2009 17:19:13 -0700 (MST) To: Joel Brobecker Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: Fix most -Wmissing-prototypes -Wmissing-declarations warnings References: <200902180201.05118.pedro@codesourcery.com> <20090220000902.GA6428@adacore.com> From: Tom Tromey Reply-To: Tom Tromey Date: Fri, 20 Feb 2009 04:01:00 -0000 In-Reply-To: <20090220000902.GA6428@adacore.com> (Joel Brobecker's message of "Thu\, 19 Feb 2009 16\:09\:02 -0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00401.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> The ada_typedef_print thing is a known oddity: >> http://sourceware.org/ml/gdb-patches/2008-09/msg00541.html Joel> ARGH! I missed that message :-(. Don't hestitate to ping me Joel> when Ada is involved, or even to take action. I would have, but I forgot about it myself :). I'll try to file a PR or something next time, if that works for you. (I find the persistence of bug reports preferable in a situation like this.) Joel> Function removed thusly: Joel> 2009-02-19 Joel Brobecker Joel> * ada-typeprint.c (ada_typedef_print): Remove. Unused. I thought perhaps you'd want to wire it into ada_lookup_partial_symbol, replacing default_print_typedef. But I don't know Ada and if the default is ok with you... Tom