From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12333 invoked by alias); 7 Dec 2009 20:13:41 -0000 Received: (qmail 12323 invoked by uid 22791); 7 Dec 2009 20:13:40 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Dec 2009 20:13:34 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB7KDBQF007956 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Dec 2009 15:13:11 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nB7KDA2c032566; Mon, 7 Dec 2009 15:13:10 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nB7KD6KW032393; Mon, 7 Dec 2009 15:13:09 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 2BA7C3782A2; Mon, 7 Dec 2009 13:13:06 -0700 (MST) From: Tom Tromey To: Tristan Gingold Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Make sym_read routines handle separate debug files References: <20091204124838.GA5764@ulanbator.act-europe.fr> <2CC5EFB8-A1BC-4025-9136-E8FA344B2C04@adacore.com> Reply-To: Tom Tromey Date: Mon, 07 Dec 2009 20:13:00 -0000 In-Reply-To: <2CC5EFB8-A1BC-4025-9136-E8FA344B2C04@adacore.com> (Tristan Gingold's message of "Mon, 7 Dec 2009 11:50:23 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00091.txt.bz2 >>>>> "Tristan" == Tristan Gingold writes: >> Could we not just keep the existing logic as a format-independent >> fallback? Tristan> I was hesitant to do that given that only ELF and some COFF Tristan> support .gnu_debuglink. I see. After I sent my note, I wondered about folks doing something like building an ELF executable, objcopy'ing it to some other format for running it, but continuing to use the ELF for debugging. Do people do that? If so then that would be a situation where the primary objfile could be of any type, but still have separate debug info. If not, then I agree your change is safe. Tristan> + debugfile = find_separate_debug_file_by_buildid (objfile); >> If this is only meaningful for ELF, as it seems to be, then it seems we >> might as well put it in elfread.c. Tristan> To be honest, I reserved this move for a following patch. Do Tristan> you prefer I resubmit this patch with this change ? If it is coming later, then I don't mind, do whatever is most convenient. Tom