From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7912 invoked by alias); 22 Dec 2009 18:49:54 -0000 Received: (qmail 7902 invoked by uid 22791); 22 Dec 2009 18:49:53 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Dec 2009 18:49:47 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBMInkUr005612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 22 Dec 2009 13:49:46 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBMInjtq027702; Tue, 22 Dec 2009 13:49:45 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nBMIniBR026257; Tue, 22 Dec 2009 13:49:45 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 511A13781B0; Tue, 22 Dec 2009 11:49:44 -0700 (MST) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix breakpoints in unloaded shared libraries References: <20091025152004.GA14740@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Tue, 22 Dec 2009 18:49:00 -0000 In-Reply-To: <20091025152004.GA14740@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sun, 25 Oct 2009 16:20:04 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00348.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> breakpoints after: Jan> warning: Temporarily disabling breakpoints for ... Jan> are currently not handled correctly and GDB does even crash (with Jan> -lmcheck). Jan> 2009-10-25 Jan Kratochvil Jan> gdb/ Jan> * breakpoint.c (bpstat_stop_status): Check BL->SHLIB_DISABLED. Jan> (print_breakpoint_location): New comment. Check LOC->SHLIB_DISABLED. Jan> Check LOC validity before printing it. Use LOC instead of B->LOC. Jan> Swap the if conditionals order. This is ok. Thanks. Tom