From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69527-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23321 invoked by alias); 13 Jan 2010 18:13:42 -0000
Received: (qmail 23312 invoked by uid 22791); 13 Jan 2010 18:13:41 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jan 2010 18:13:37 +0000
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0DIDZZx018368 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <gdb-patches@sourceware.org>; Wed, 13 Jan 2010 13:13:35 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0DIDYKB003112; 	Wed, 13 Jan 2010 13:13:35 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o0DIDYLq009798; 	Wed, 13 Jan 2010 13:13:34 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id B943A37819A; Wed, 13 Jan 2010 11:13:33 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch][python] Implement Python lazy strings (PR 10705)
References: <4B4746A7.90309@redhat.com> <m3y6k4nydr.fsf@fleche.redhat.com> 	<4B4DDD7B.5080204@redhat.com>
Reply-To: tromey@redhat.com
Date: Wed, 13 Jan 2010 18:13:00 -0000
In-Reply-To: <4B4DDD7B.5080204@redhat.com> (Phil Muldoon's message of "Wed, 13 	Jan 2010 14:49:31 +0000")
Message-ID: <m36375j2k2.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-01/txt/msg00351.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> Here is an updated patch. What do you think?

A couple more notes.

Phil> +gdbpy_extract_lazy_string (PyObject *string, struct type **str_type,
Phil> +		     long *length, char **encoding)
Phil> +{
[...]
Phil> +  py_len = PyObject_GetAttrString (string, "length");
Phil> +  py_encoding = PyObject_GetAttrString (string, "encoding");
Phil> +  py_addr = PyObject_GetAttrString (string, "address");
Phil> +  py_type = PyObject_GetAttrString (string, "type");
[...]
Phil> +  Py_DECREF (py_len);
Phil> +  Py_XDECREF (py_encoding);

Nothing ever frees py_addr or py_type.
This is true for the error case as well.

Phil> +PyObject *execute_pretty_printer (PyObject *printer);

This is declared but never defined or used.

Tom