From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19024 invoked by alias); 19 Feb 2010 03:10:38 -0000 Received: (qmail 19014 invoked by uid 22791); 19 Feb 2010 03:10:37 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Feb 2010 03:10:34 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1J3AWLW006360 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Feb 2010 22:10:32 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1J3AWhT014061; Thu, 18 Feb 2010 22:10:32 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o1J3AVsa006658; Thu, 18 Feb 2010 22:10:31 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id BD9FE378212; Thu, 18 Feb 2010 20:10:30 -0700 (MST) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix crash on stale addrinfo->sectindex References: <20100218092203.GA31309@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Fri, 19 Feb 2010 03:10:00 -0000 In-Reply-To: <20100218092203.GA31309@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Thu, 18 Feb 2010 10:22:03 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00476.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> 2010-02-18 Jan Kratochvil Jan> * symfile.c (addr_info_make_relative): Extend comment. Move SECT to Jan> a more inner block. Initialize ADDR by LOWER_OFFSET only if it was Jan> found by bfd_get_section_by_name. Jan> * symfile.h (struct section_addr_info) : New comment. Oh, by the way, I think this is reasonable for 7.1. It is straightforward and fixes a reported crash. If Joel agrees, please put it on the branch. Thanks. Tom