From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23933 invoked by alias); 1 Mar 2010 19:25:58 -0000 Received: (qmail 23899 invoked by uid 22791); 1 Mar 2010 19:25:57 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Mar 2010 19:25:51 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o21JPoJ9011241 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Mar 2010 14:25:50 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o21JPnDb000421; Mon, 1 Mar 2010 14:25:49 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o21JPmxn020748; Mon, 1 Mar 2010 14:25:48 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 050B1378267; Mon, 1 Mar 2010 12:25:47 -0700 (MST) From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds References: <20100228130500.GG5683@calimero.vinschen.de> <20100228142905.GB1556@caradoc.them.org> <20100228150318.GA32463@calimero.vinschen.de> <20100228184749.GA17375@caradoc.them.org> <20100228192159.GP5683@calimero.vinschen.de> <20100228222702.GC29360@caradoc.them.org> <20100301103125.GB9730@calimero.vinschen.de> <20100301173054.GD5683@calimero.vinschen.de> Reply-To: tromey@redhat.com Date: Mon, 01 Mar 2010 19:25:00 -0000 In-Reply-To: <20100301173054.GD5683@calimero.vinschen.de> (Corinna Vinschen's message of "Mon, 1 Mar 2010 18:30:54 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00028.txt.bz2 >>>>> "Corinna" == Corinna Vinschen writes: Tom> I think the documentation for these functions (in charset.h) should Tom> mention the expected lifetime of the arguments. Corinna> I don't understand. What do you mean by "expected lifetime"?!? The argument string must not be freed by the caller. Tom> This seems to introduce an ordering dependency between _initialize Tom> functions. My understanding is that we don't allow this. Corinna> It's just a default. The default of UTF-32 breaks wide char Corinna> support for UTF-16 targets. A native Cygwin or MingW GDB Corinna> should have a sane default for the target charsets. That's all Corinna> I'm trying to accomplish. Yes, I understand. The problem here is that if the init functions are ordered one way, then your patch installs one default, but if they are ordered another way, then your patch installs a different default. Personally, I think that, given the existing nl_langinfo code (and worse, Solaris hack) in _initialize_charset, it would be fine to add some Cygwin change here. However, I won't approve a patch like that over Daniel's objections. Tom