From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28250 invoked by alias); 30 Apr 2010 18:21:35 -0000 Received: (qmail 28235 invoked by uid 22791); 30 Apr 2010 18:21:33 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Apr 2010 18:21:28 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3UILIpO009364 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 30 Apr 2010 14:21:18 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3UILHT7028386; Fri, 30 Apr 2010 14:21:17 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3UILG0h026508; Fri, 30 Apr 2010 14:21:16 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id F02893795F9; Fri, 30 Apr 2010 12:21:15 -0600 (MDT) From: Tom Tromey To: Stan Shebs Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Observer mode References: <4BD9C057.9090805@codesourcery.com> Reply-To: tromey@redhat.com Date: Fri, 30 Apr 2010 18:21:00 -0000 In-Reply-To: <4BD9C057.9090805@codesourcery.com> (Stan Shebs's message of "Thu, 29 Apr 2010 10:22:31 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg01010.txt.bz2 >>>>> "Stan" == Stan Shebs writes: Stan> We have been calling this "observer mode", and the customer's GDB Stan> is actually configured to launch in this mode, to reduce the Stan> chance of accidental stopping - the debugger user has to ask Stan> specifically to change it to normal debugging mode. It seems like a reasonable feature to me. I can't really comment on the implementation approach. Stan> #include "gdbcmd.h" Stan> #include "value.h" Stan> #include "target.h" Stan> + extern int may_insert_tracepoints; Stan> + extern int may_insert_fast_tracepoints; Stan> #include "language.h" Stan> #include "gdb_string.h" Stan> #include "inferior.h" The placement of these declarations seems rather odd. I seem to keep running across this sort of thing for tracepoints. I think a tracepoint-implementation-specific header file would be cleaner. Tom