From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10922 invoked by alias); 7 May 2010 17:29:47 -0000 Received: (qmail 10913 invoked by uid 22791); 7 May 2010 17:29:46 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 May 2010 17:29:42 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o47HTHHp029153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 May 2010 13:29:18 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o47HTGBw022432; Fri, 7 May 2010 13:29:17 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o47HTGRB015619; Fri, 7 May 2010 13:29:16 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id C287C378183; Fri, 7 May 2010 11:29:15 -0600 (MDT) From: Tom Tromey To: Joel Brobecker Cc: Michael Snyder , "gdb-patches\@sourceware.org" Subject: Re: [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables References: <4BE35310.9020704@vmware.com> <20100507031644.GZ2768@adacore.com> Reply-To: tromey@redhat.com Date: Fri, 07 May 2010 17:29:00 -0000 In-Reply-To: <20100507031644.GZ2768@adacore.com> (Joel Brobecker's message of "Thu, 6 May 2010 20:16:44 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00189.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> --- jv-lang.c 22 Apr 2010 23:15:41 -0000 1.83 >> +++ jv-lang.c 6 May 2010 23:35:37 -0000 >> @@ -268,8 +268,10 @@ type_from_class (struct gdbarch *gdbarch >> struct value *utf8_name; >> char *nptr; >> CORE_ADDR addr; >> +#if 0 >> struct block *bl; >> struct dict_iterator iter; >> +#endif Joel> Can you explain why using #if 0 instead of deleting these variables? I looked at that, too. There is (pseudo-)code that references these variables, also in #if 0. I think any code in jv-* that has been #if 0 for 10 years can be deleted with no loss. Tom