From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73210-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20862 invoked by alias); 21 May 2010 17:20:24 -0000
Received: (qmail 20842 invoked by uid 22791); 21 May 2010 17:20:23 -0000
X-SWARE-Spam-Status: No, hits=-5.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 May 2010 17:20:17 +0000
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4LHJlOv002253	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 21 May 2010 13:19:48 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4LHJkHZ002929;	Fri, 21 May 2010 13:19:46 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o4LHJg9W004458;	Fri, 21 May 2010 13:19:43 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 7CD7937818E; Fri, 21 May 2010 11:19:42 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: "'Joel Brobecker'" <brobecker@adacore.com>, <gdb-patches@sourceware.org>,        "'FPC Core Developer List'" <core@freepascal.org>
Subject: Re: [RFA-v2] dwarf debug format: Support DW_AT_variable_parameter attribute
References: <8830.7035308846$1273670829@news.gmane.org>	<m34oibvhgh.fsf@fleche.redhat.com> <20100517172758.GJ2805@adacore.com>	<000301caf5e7$222ac800$66805800$@muller@ics-cnrs.unistra.fr>	<20100517174726.GK2805@adacore.com>	<44296.7587885962$1274132782@news.gmane.org>	<m3fx1n90ul.fsf@fleche.redhat.com>	<28559.2589797036$1274302480@news.gmane.org>	<m31vd78rxr.fsf@fleche.redhat.com>	<27418.1569614031$1274308493@news.gmane.org>
Reply-To: tromey@redhat.com
Date: Fri, 21 May 2010 17:44:00 -0000
In-Reply-To: <27418.1569614031$1274308493@news.gmane.org> (Pierre Muller's	message of "Thu, 20 May 2010 00:34:07 +0200")
Message-ID: <m3632h18b5.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00503.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>   Does that look OK?

Pierre> 2010-05-20  Pierre Muller  <muller@ics.u-strasbg.fr>
Pierre> 	* dwarf2read.c (new_symbol): Handle DW_AT_variable_parameter
Pierre> 	attribute.

This is ok.

I think it would be improved by a test case, but that is up to you.

Tom