From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7674 invoked by alias); 20 Jul 2010 22:03:44 -0000 Received: (qmail 7577 invoked by uid 22791); 20 Jul 2010 22:03:43 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Jul 2010 22:03:38 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6KM3bCE020079 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Jul 2010 18:03:37 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6KM3bwg021705; Tue, 20 Jul 2010 18:03:37 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6KM3aPV015342; Tue, 20 Jul 2010 18:03:36 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 140023797EE; Tue, 20 Jul 2010 16:03:36 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix internal error on library without dirname References: <20100720214451.GA28276@host1.dyn.jankratochvil.net> Date: Tue, 20 Jul 2010 22:03:00 -0000 In-Reply-To: <20100720214451.GA28276@host1.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue, 20 Jul 2010 23:44:51 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00323.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> Starting program: [...] Jan> ../../gdb/symfile.c:1326: internal-error: find_separate_debug_file_by_debuglink: Assertion `i >= 0 && IS_DIR_SEPARATOR (dir[i])' failed. Jan> A problem internal to GDB has been detected, Thanks. Jan> I believe it could go for 7.2. I agree. Jan> * symfile.c (find_separate_debug_file_by_debuglink): Remove Jan> a gdb_assert call, new comment. There is a comment just before the loop above the assert that is now invalid: /* Strip off the final filename part, leaving the directory name, followed by a slash. Objfile names should always be absolute and tilde-expanded, so there should always be a slash in there somewhere. */ This patch is ok with some suitable change to this comment. Tom