From: Tom Tromey <tromey@redhat.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] smart pointer support
Date: Mon, 09 Aug 2010 17:35:00 -0000 [thread overview]
Message-ID: <m362zjk7up.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4C6025EF.5080509@redhat.com> (sami wagiaalla's message of "Mon, 09 Aug 2010 11:59:43 -0400")
>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:
Tom> This seems strange. When can the result here be NULL? And what does
Tom> that mean? It seems like this either ought to be impossible, or it
Tom> should be an error of some kind.
Sami> Yes this is incorrect. value_x_unop never returns null. If the
Sami> operator is not found it throws an error. I added a try catch
Sami> statement and tests for the failing case.
Why a try/catch? I would think that letting any error propagate would
be more appropriate.
Tom
next prev parent reply other threads:[~2010-08-09 17:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 15:58 sami wagiaalla
2010-07-23 23:37 ` Tom Tromey
2010-08-05 18:46 ` sami wagiaalla
2010-08-05 22:57 ` Ulrich Weigand
2010-08-06 16:23 ` sami wagiaalla
2010-08-06 16:48 ` Ulrich Weigand
2010-08-06 17:29 ` Tom Tromey
2010-08-08 15:01 ` Ulrich Weigand
2010-08-06 21:33 ` sami wagiaalla
2010-08-06 22:20 ` Tom Tromey
2010-08-09 15:59 ` sami wagiaalla
2010-08-09 17:35 ` Tom Tromey [this message]
2010-08-09 18:04 ` sami wagiaalla
2010-08-09 18:23 ` Jan Kratochvil
2010-08-16 20:31 ` sami wagiaalla
2010-08-16 20:59 ` Pedro Alves
2010-08-17 16:16 ` sami wagiaalla
2010-08-17 17:15 ` Tom Tromey
2010-10-19 20:55 ` sami wagiaalla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m362zjk7up.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=swagiaal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox