From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75251-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10686 invoked by alias); 30 Aug 2010 20:01:14 -0000
Received: (qmail 10407 invoked by uid 22791); 30 Aug 2010 20:01:13 -0000
X-SWARE-Spam-Status: No, hits=-6.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Aug 2010 20:01:08 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7UK16p7020174	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 30 Aug 2010 16:01:07 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7UK16lw023725;	Mon, 30 Aug 2010 16:01:06 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7UK15MO020164;	Mon, 30 Aug 2010 16:01:05 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id D36F837822B; Mon, 30 Aug 2010 14:01:04 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix overload resolution of int* vs void*
References: <4C7BCD42.9070308@redhat.com>
Date: Mon, 30 Aug 2010 20:01:00 -0000
In-Reply-To: <4C7BCD42.9070308@redhat.com> (sami wagiaalla's message of "Mon,	30 Aug 2010 11:24:50 -0400")
Message-ID: <m362yrkgzj.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-08/txt/msg00533.txt.bz2

>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:

Sami> A fix for this bug http://sourceware.org/bugzilla/show_bug.cgi?id=10343
Sami> This patch makes it a little bit cheaper to convert a pointer to void*
Sami> than any other pointer conversion.

Consider this test:

    struct B { };
    struct D : public B { };
    void f (void *x) { }
    void f (B *x) { }
    void g(D *x) { f(x); }

This should call f(B*), but with your patch I suspect it will call
f(void*).

Tom