From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76205-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14057 invoked by alias); 26 Oct 2010 15:37:07 -0000
Received: (qmail 13931 invoked by uid 22791); 26 Oct 2010 15:37:06 -0000
X-SWARE-Spam-Status: No, hits=-6.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Oct 2010 15:37:02 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9QFab4R012132	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 26 Oct 2010 11:36:37 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o9QFabu2001515;	Tue, 26 Oct 2010 11:36:37 -0400
Received: from parfait.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o9QFaZe7015575;	Tue, 26 Oct 2010 11:36:35 -0400
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Doug Evans <dje@google.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix avoiding of unnecessary psymtabs in dwarf_decode_lines
References: <20100825000001.9D9A484B8E@ruffy.mtv.corp.google.com>	<20101026133928.GB2847@adacore.com>
Date: Tue, 26 Oct 2010 15:37:00 -0000
In-Reply-To: <20101026133928.GB2847@adacore.com> (Joel Brobecker's message of	"Tue, 26 Oct 2010 09:39:28 -0400")
Message-ID: <m362wpotc3.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-10/txt/msg00370.txt.bz2

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> I know that the original code was already using strcmp to do the
Joel> comparison, but shouldn't we be using FILENAME_CMP instead.  That should
Joel> take care of platforms where the filesystem is case insensitive...

Joel> Since the patch was sent so long ago, I can make the change and do
Joel> the testing, if people agree.

It seems reasonable to me.

Tom