Re: [PATCH 2/6] Introduce `pre_expanded sals'

Sergio Durigan Junior
2011-08-05T18:06:12Z

Tom Tromey <tromey@redhat.com> writes:

> Sergio> All right, I see what you mean. Personally, I think that if this
> Sergio> behavior happens, then it means we should probably fix linespec in order
> Sergio> to evaluate the `probe:' part earlier.
>
> I hadn't thought of that. It seems insufficient to me, though. Suppose
> that "break probe:something" matches both a probe named "something" and
> a function in the executable "probe". In this case, the breakpoint will
> have to match both locations (due to the spec I'm implementing), but in
> a way the locations would have very different meanings.

Hm, ok. I was thinking superficially about the problem, and assuming
that we would only accept the `probe:' for stap probes. Anyway, you're
right, it would be much more difficult to handle this case.

> Sergio> As I said in the beginning, I'm OK with that change. But obviously I'm
> Sergio> not a maintainer, and I'm also an interested part in this being accepted
> Sergio> :-).
>
> I'm going to work on it then.

Thanks a lot!