From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6344 invoked by alias); 9 Nov 2011 18:41:07 -0000 Received: (qmail 6336 invoked by uid 22791); 9 Nov 2011 18:41:06 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Nov 2011 18:40:50 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA9Ieinv017125 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 Nov 2011 13:40:44 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA9Iei2U022422; Wed, 9 Nov 2011 13:40:44 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA9Iegrn022522; Wed, 9 Nov 2011 13:40:42 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, Ulrich Weigand Subject: Re: RFC: don't set the pspace on ordinary breakpoints References: <201111091830.31856.pedro@codesourcery.com> Date: Wed, 09 Nov 2011 18:41:00 -0000 In-Reply-To: <201111091830.31856.pedro@codesourcery.com> (Pedro Alves's message of "Wed, 9 Nov 2011 18:30:31 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00250.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> @@ -1327,6 +1329,12 @@ decode_indirect (struct linespec_state *self, >> char **argptr) >> CORE_ADDR pc; >> char *initial = *argptr; >> >> + if (current_program_space->executing_startup) >> + /* The error message doesn't really matter, because this case >> + should only hit during breakpoint reset. */ >> + throw_error (NOT_FOUND_ERROR, _("cannot evaluate expressions while " >> + "program space is in startup")); Pedro> Why is is okay to look at current_program_space here, if you're Pedro> iterating over pspaces elsewhere? decode_indirect is for 'break *EXPRESSION', which is only evaluated in the current context in the current program space. Pedro> Any chance we can have a standalone patch for just the Pedro> startup-disabled changes? We'd need something like my previous Pedro> suggestion in bkpt_re_set (even if we'd remain buggy WRT Pedro> multi-process). Sure, I will do that. Tom