From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28860 invoked by alias); 16 Jan 2014 05:22:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28841 invoked by uid 89); 16 Jan 2014 05:22:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2014 05:22:25 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0G5MNTn015153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Jan 2014 00:22:23 -0500 Received: from psique (ovpn-113-91.phx2.redhat.com [10.3.113.91]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0G5MJY9015269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 16 Jan 2014 00:22:21 -0500 From: Sergio Durigan Junior To: Michael Eager Cc: gdb-patches ml , Keith Seitz Subject: Re: [PATCH] Regression setting breakpoint References: <52A8CD31.5090809@eagerm.com> X-URL: http://www.redhat.com Date: Thu, 16 Jan 2014 05:22:00 -0000 In-Reply-To: <52A8CD31.5090809@eagerm.com> (Michael Eager's message of "Wed, 11 Dec 2013 12:38:09 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00584.txt.bz2 On Wednesday, December 11 2013, Michael Eager wrote: > From 6e6a7110f950e3d90978637b21fcb913934be9b1 Mon Sep 17 00:00:00 2001 > From: Michael Eager > Date: Tue, 10 Dec 2013 11:50:27 -0800 > Subject: [PATCH] Fix regression symbol name different from linkage name. > > gdb: > * dwarf2read.c (die_needs_namespace): Do nothing for C language. > > testsuite: > * gdb.base/break-linker-symname.c: New. > * gdb.base/break-linker-symname.exp: New. Not really a code review, but the ChangeLog entries should be of the form: 2014-01-16 Your Name * file.c (function): What changed. Also... > diff --git a/gdb/testsuite/gdb.base/break-linker-symname.exp b/gdb/testsuite/gdb.base/break-linker-symname.exp > new file mode 100644 > index 0000000..2a86f37 > --- /dev/null > +++ b/gdb/testsuite/gdb.base/break-linker-symname.exp > @@ -0,0 +1,25 @@ > +# Copyright 2013 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# Test that 'set breakpoint always-inserted 1' is not a brick > +# Also verifies that breakpoint enabling/disabling works properly > +# with duplicated breakpoints. > + > +if { [prepare_for_testing break-linker-symname.exp break-linker-symname break-linker-symname.c] } { > + return -1 > +} You can rewrite this part as: ----- standard_testfile if { [prepare_for_testing $testfile.exp $testfile $srcfile] } { return -1 } ----- Thanks, -- Sergio