From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68426 invoked by alias); 18 May 2015 05:49:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68413 invoked by uid 89); 18 May 2015 05:49:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f177.google.com Received: from mail-pd0-f177.google.com (HELO mail-pd0-f177.google.com) (209.85.192.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 18 May 2015 05:49:02 +0000 Received: by pdea3 with SMTP id a3so133388217pde.2 for ; Sun, 17 May 2015 22:49:01 -0700 (PDT) X-Received: by 10.68.224.10 with SMTP id qy10mr41866062pbc.23.1431928141091; Sun, 17 May 2015 22:49:01 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id ry2sm8683615pbb.83.2015.05.17.22.49.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 May 2015 22:49:00 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4 5/9] Explicit locations: introduce probe locations References: <20150507180523.19629.77846.stgit@valrhona.uglyboxes.com> <20150507180557.19629.42306.stgit@valrhona.uglyboxes.com> Date: Mon, 18 May 2015 05:49:00 -0000 In-Reply-To: <20150507180557.19629.42306.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Thu, 07 May 2015 11:05:57 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00453.txt.bz2 Keith Seitz writes: > This patch adds support for probe locations and converts existing > probe linespec locations to the new location type. > > gdb/ChangeLog: > > * break-catch-throw.c (re_set_exception_catchpoint): Convert > linespec for stap probe to probe location. > * breakpoint.c (create_longjmp_master_breakpoint): Likewise. > (create_exception_master_breakpoint): Likewise. > (break_command_1): Remove local variable `arg_cp'. > Check location type to set appropriate breakpoint ops methods. > (trace_command): Likewise. > * linespec.c (event_location_to_sals): Assert on probe locations. > * location.c (EL_PROBE): Add macro definition. > (new_probe_location, get_probe_location): New functions. > (copy_event_location): Handle probe locations. > (delete_event_location): Likewise. > (event_location_to_string): Likewise. > (string_to_event_location): Likewise. > (event_location_empty_p): Likewise. > * location.h (enum event_location_type): Add PROBE_LOCATION. > (new_probe_location, get_probe_location): Declare. > * probe.c (parse_probes): Assert that LOCATION is a probe location. > Convert linespec into probe location. LGTM