Re: [RFA] win32-nat.c: Simplify generation of Windows environment

Eli Zaretskii
2006-12-08T11:31:00Z

> Date: Fri, 8 Dec 2006 10:12:41 +0100
> From: Corinna Vinschen <vinschen@redhat.com>
>
> How exactly are we supposed to think of and support code which is not
> part of the source tree when creating a patch?

You aren't required to think about it. My request was just that---a
request, not an attempt to say that you made some grave mistake.

> As I just wrote in my reply to Jim, the cygwin_internal API is used in
> GDB for a long time, as a grep will show. If win32-nat.c is used by
> some not-in-the-source-tree code somewere, it will already have to deal
> with cygwin_internal. A patch for a native GDB will have created either
> a matching #define or a substitute for this function anyway. I don't
> see how this new usage differs from the existing ones.

I really fail to understand the fuss that my simple request
generated. All I asked for is 2 lines:

#ifdef __CYGWIN__
...
#endif