From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29979 invoked by alias); 8 Dec 2006 00:09:33 -0000 Received: (qmail 29971 invoked by uid 22791); 8 Dec 2006 00:09:33 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 08 Dec 2006 00:09:26 +0000 Received: (qmail 26856 invoked from network); 8 Dec 2006 00:09:25 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Dec 2006 00:09:25 -0000 To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFA] win32-nat.c: Simplify generation of Windows environment References: <20061207095839.GA14487@calimero.vinschen.de> From: Jim Blandy Date: Fri, 08 Dec 2006 00:09:00 -0000 In-Reply-To: (Eli Zaretskii's message of "Thu, 07 Dec 2006 23:37:02 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00108.txt.bz2 Eli Zaretskii writes: >> Date: Thu, 7 Dec 2006 10:58:39 +0100 >> From: Corinna Vinschen >> >> the below patch simplifies the code which translates the Cygwin >> environment into the native Windows environment. So far this is >> done in GDB manually. However, there's a Cygwin specific function >> call which does the same for the calling process. Using this call >> has three advantages. > > Is win32-nat.c used only for the Cygwin build? I thought the native > Windows build used it as well (perhaps with a few patches that are not > yet part of the CVS), but maybe I was mistaken. > > If I am right, then please make this change, and especially the call > to cygwin_internal, conditioned on __CYGWIN__, or some other > Cygwin-specific symbol. $ cd gdb/config $ grep -nH -e win32-nat */*.m? i386/cygwin.mh:2:NATDEPFILES= i386-nat.o win32-nat.o corelow.o $ I think that means it's just Cygwin.