From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32487 invoked by alias); 11 Jun 2007 18:03:07 -0000 Received: (qmail 32478 invoked by uid 22791); 11 Jun 2007 18:03:06 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 11 Jun 2007 18:03:04 +0000 Received: (qmail 731 invoked from network); 11 Jun 2007 18:03:03 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 Jun 2007 18:03:03 -0000 To: "Ulrich Weigand" Cc: gdb-patches@sourceware.org Subject: Re: [1/3] Remove gdbarch-swapping of remote_address_masked References: <200706082322.l58NMZAD019415@d12av02.megacenter.de.ibm.com> From: Jim Blandy Date: Mon, 11 Jun 2007 18:03:00 -0000 In-Reply-To: <200706082322.l58NMZAD019415@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Sat, 9 Jun 2007 01:22:35 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00151.txt.bz2 "Ulrich Weigand" writes: > remote.c contains a gdbarch-swapped variable "remote_address_masked". The > swap function in fact re-sets the variable to the default address size of > the target. > > This patch attempts to decouple changes to the variable by the user > (via "set remoteaddresssize") from changes due to architecture switches: > > - If the user sets the variable, that value is subsequently used (even > if the architecture switches). > > - If the user never used "set remoteaddresssize" (i.e. the variable > reads 0), remote_address_masked implicitly uses the current target's > address size instead. > > > Now this is certainly a change in behaviour, but I'd think the new way > should actually be more useful ... > > Any comments from users of that functionality? Does this make sense? It seems to me that this makes the remoteaddresssize setting behave much like language settings: there's 'auto (currently blargh)' and 'blargh'. To be honest, I don't think it's worthwhile making this variable actually behave that way. I don't even want to know what it was added for.