From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 981 invoked by alias); 6 Feb 2009 21:11:43 -0000 Received: (qmail 973 invoked by uid 22791); 6 Feb 2009 21:11:43 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Feb 2009 21:11:37 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n16LBZj2008562 for ; Fri, 6 Feb 2009 16:11:35 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n16LBb53024588 for ; Fri, 6 Feb 2009 16:11:37 -0500 Received: from opsy.redhat.com (vpn-13-153.rdu.redhat.com [10.11.13.153]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n16LBYTX015484; Fri, 6 Feb 2009 16:11:34 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 173AE8880B9; Fri, 6 Feb 2009 14:11:28 -0700 (MST) To: Vladimir Prus Cc: gdb-patches@sources.redhat.com, Nick Roberts , Marc Khouzam Subject: Re: [RFA] fix *stopped for CLI commands References: <200902061045.18508.vladimir@codesourcery.com> From: Tom Tromey Reply-To: tromey@redhat.com Date: Fri, 06 Feb 2009 21:11:00 -0000 In-Reply-To: <200902061045.18508.vladimir@codesourcery.com> (Vladimir Prus's message of "Fri\, 6 Feb 2009 10\:45\:18 +0300") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00158.txt.bz2 >>>>> "Vladimir" == Vladimir Prus writes: Vladimir> This patch fixes this by making MI observer print frame Vladimir> again, into MI uiout, if necessary. It passes all MI tests Vladimir> in (sync,async)x(native,gdbserver) combinations. How does Vladimir> this look, and are non-MI changes OK? If approved, I'll add Vladimir> a test that CLI commands result in proper *stopped. I don't understand all the implications of the core change, but I do like how it moves some MI logic out of the core and into MI. Vladimir> -@deftypefun void normal_stop (struct bpstats *@var{bs}) Vladimir> +@deftypefun void normal_stop (struct bpstats *@var{bs}, int @var{print_frame}) Vladimir> The inferior has stopped for real. Vladimir> @end deftypefun I would like to ask for documentation describing the meaning of the new argument. Tom