From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23037 invoked by alias); 14 Oct 2009 22:57:12 -0000 Received: (qmail 23029 invoked by uid 22791); 14 Oct 2009 22:57:12 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Oct 2009 22:57:06 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9EMv5L7031396 for ; Wed, 14 Oct 2009 18:57:05 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9EMv4Sm019961; Wed, 14 Oct 2009 18:57:04 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n9EMv3Fx003274; Wed, 14 Oct 2009 18:57:03 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id B509A37828F; Wed, 14 Oct 2009 16:57:02 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Performance optimize large bp_location count References: <20090904201706.GA26300@host0.dyn.jankratochvil.net> <20091013223510.GA29950@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Wed, 14 Oct 2009 22:57:00 -0000 In-Reply-To: <20091013223510.GA29950@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Wed, 14 Oct 2009 00:35:11 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00325.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> Still just this way it was a minimal changeset to get the same user Jan> experience as the best breakpoints-modifying patch could be. After Jan> other parts of GDB (symbol lookups) get accelerated more work may Jan> be useful on this part. This sounds reasonable to me. Tom> I puzzled over the choice of a sorted array here, wondering if there Tom> were perhaps some better data structure. A bit of rationale and Tom> overview in the patch email would go a long way. Jan> I do not remember it all but probably I just did not consider the Jan> possibility of an incremental update, I tried the most easy patch Jan> and it worked. Different data structure would be more appropriate Jan> for the incremental update. Thanks for this and your explanations, they were very useful. Tom> It isn't obvious to me why this finds the leftmost element when there Tom> are multiple overlapping ones. What am I missing? Jan> Maybe another comment? (put there one before "if (b->...)") Thanks. Jan> 2009-10-14 Jan Kratochvil Jan> Performance optimize large bp_location count. Jan> * breakpoint.c (ALL_BP_LOCATIONS_SAFE): Remove. [...] Ok. Tom