From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29862 invoked by alias); 4 Dec 2009 18:13:12 -0000 Received: (qmail 29854 invoked by uid 22791); 4 Dec 2009 18:13:12 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Dec 2009 18:13:05 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB4ID4Yg011011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Dec 2009 13:13:04 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nB4ID3MV026643; Fri, 4 Dec 2009 13:13:03 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nB4ID2ls021561; Fri, 4 Dec 2009 13:13:03 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 9067C378183; Fri, 4 Dec 2009 11:13:02 -0700 (MST) From: Tom Tromey To: Phil Muldoon Cc: gdb-patches ml Subject: Re: [python][patch] And range method to type References: <4B1929DC.7070809@redhat.com> Reply-To: tromey@redhat.com Date: Fri, 04 Dec 2009 18:13:00 -0000 In-Reply-To: <4B1929DC.7070809@redhat.com> (Phil Muldoon's message of "Fri, 04 Dec 2009 15:25:16 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00061.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> This patch adds a "range" method for GDB.Types. It only supports types Phil> that support a range, or the range type itself. Phil> + if (TYPE_CODE (type) != TYPE_CODE_ARRAY && Phil> + TYPE_CODE (type) != TYPE_CODE_STRING && Phil> + TYPE_CODE (type) != TYPE_CODE_RANGE) In the GNU style, the "&&"s go at the start of the line. I think this code should check for failures from PyLong_FromLong and PyTuple_SetItem. I realize that is a pain, but if one of those does fail, a failure to check will yield weird problems. Phil> Return a type of pointer to this type." }, Phil> + { "range", typy_range, METH_NOARGS, Phil> + "range () -> Tuple\n\ It should be "tuple", as that is the name of the returned type. Tom