From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27867 invoked by alias); 20 Apr 2010 15:43:33 -0000 Received: (qmail 27857 invoked by uid 22791); 20 Apr 2010 15:43:32 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Apr 2010 15:43:25 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3KFgrPA021989 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Apr 2010 11:42:53 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3KFgqW7008871; Tue, 20 Apr 2010 11:42:52 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3KFgojM011449; Tue, 20 Apr 2010 11:42:51 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 745D037979C; Tue, 20 Apr 2010 09:42:50 -0600 (MDT) From: Tom Tromey To: crquan@gmail.com Cc: gdb-patches@sourceware.org, Eli Zaretskii , Nathan Froyd , Hui Zhu , Joel Brobecker Subject: Re: [PATCH] disassemble support start,+length format References: <1270739689-28732-1-git-send-email-crquan@gmail.com> <1271382149-15177-1-git-send-email-crquan@gmail.com> Reply-To: tromey@redhat.com Date: Tue, 20 Apr 2010 15:43:00 -0000 In-Reply-To: <1271382149-15177-1-git-send-email-crquan@gmail.com> (crquan@gmail.com's message of "Fri, 16 Apr 2010 09:42:29 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00611.txt.bz2 >>>>> ">" == Cheng Renquan writes: >> +2010-04-15 CHENG Renquan >> + >> + * gdb/cli/cli-cmds.c (disassemble_command): Add support of disassemble >> + "start,+length" form of arguments. >> + * gdb/doc/gdb.texinfo: Update disassemble description of two forms of >> + arguments, and add new example to demonstrate the new form. A couple notes on the ChangeLog entry. First, file names should be relative to the directory holding the ChangeLog file. So, the leading "gdb/" should be removed. Second, doc/ has its own ChangeLog, so you don't need an entry for it in gdb/ChangeLog. Third, the NEWS change should be mentioned. This patch is ok with those updates, once your paperwork is all done. Be sure to let us know when that happens. Tom