From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28002 invoked by alias); 20 Apr 2010 21:39:49 -0000 Received: (qmail 27990 invoked by uid 22791); 20 Apr 2010 21:39:48 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Apr 2010 21:39:43 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3KLdJuD025359 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Apr 2010 17:39:19 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3KLdIZo032458; Tue, 20 Apr 2010 17:39:18 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3KLdHcm014306; Tue, 20 Apr 2010 17:39:18 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 532A237979C; Tue, 20 Apr 2010 15:39:17 -0600 (MDT) From: Tom Tromey To: Mihail Zenkov Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: D language support References: <20091224015617.7092112b.mihai.zenkov@gmail.com> <20091230125539.GF2788@adacore.com> <20100109082524.263bcb17.mihai.zenkov@gmail.com> <20100109082830.dd984de8.mihai.zenkov@gmail.com> <20100109142327.GC2007@adacore.com> <20100113064026.14f75ff2.mihai.zenkov@gmail.com> <20100415012124.91ce1769.mihai.zenkov@gmail.com> Reply-To: tromey@redhat.com Date: Tue, 20 Apr 2010 21:39:00 -0000 In-Reply-To: <20100415012124.91ce1769.mihai.zenkov@gmail.com> (Mihail Zenkov's message of "Thu, 15 Apr 2010 01:21:24 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00648.txt.bz2 >>>>> "Mihail" == Mihail Zenkov writes: Mihail> Sorry for too very long delay. I fix patch as you and Joel Mihail> suggested, i hope it ready for inclusion. It is very close. In fact, I think I only saw formatting nits. Thanks for working on this. I think this needs a NEWS entry. Mihail> gdb/ChangeLog: [...] Mihail> * doc/gdb.texinfo: Add mention about D language support. [...] Mihail> * testsuite/gdb.base/default.exp: Fix "set language" test. These directories have their own ChangeLog files, so you have to split up the entry. Mihail> +extern void c_emit_char (int c, struct type *type, struct ui_file *stream, int quoter); This wraps past 80 columns, so it should be split after the second comma. Mihail> +static const char* mangled_str; GDB style is "const char *mangled_str" -- the "*" is in the wrong place. Mihail> + obstack_blank(&tempbuf, -1); Space before open paren. Mihail> + } else if (strncmp (mangled_str, "__Class_", 8) == 0) Newline before "else". Mihail> +extern int d_val_print (struct type *type, const gdb_byte *valaddr, Mihail> + int embedded_offset, CORE_ADDR address, Mihail> + struct ui_file *stream, int recurse, Mihail> + const struct value_print_options *options); Mihail> +#endif /* !defined (D_LANG_H) */ Blank line before the #endif. thanks, Tom