From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21671 invoked by alias); 13 May 2010 17:29:14 -0000 Received: (qmail 21662 invoked by uid 22791); 13 May 2010 17:29:13 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 May 2010 17:29:08 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4DHT3fZ002615 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 May 2010 13:29:04 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4DHT38B023036; Thu, 13 May 2010 13:29:03 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o4DHT2vY005696; Thu, 13 May 2010 13:29:02 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 3CD8537881C; Thu, 13 May 2010 11:29:02 -0600 (MDT) From: Tom Tromey To: "Pierre Muller" Cc: Subject: Re: [RFA] dwarf debug format: Support DW_AT_variable_parameter attribute References: <8830.7035308846$1273670829@news.gmane.org> Reply-To: tromey@redhat.com Date: Thu, 13 May 2010 17:51:00 -0000 In-Reply-To: <8830.7035308846$1273670829@news.gmane.org> (Pierre Muller's message of "Wed, 12 May 2010 15:27:11 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00280.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Pierre> Free Pascal compiler has support for Pierre> DW_AT_variable_parameter attribute, but this is disabled because Pierre> GDB does not support it yet. Pierre> The value of the attribute must be a flag according to Pierre> DWARF specs. The only point I am unsure about is Pierre> what does a zero value of this flag mean: Pierre> Should zero be considered as FALSE and Pierre> thus the should say that this parameter is NOT a variable parameter, Pierre> or does the simple presence of this attribute condfirm Pierre> this it is a variable parameter, no matter the value of the flag. Pierre> I took the first approach here, but have the impression Pierre> that it is not always the case inside dwarf2read.c code. I think you made the correct choice. Pierre> Is this OK? I wonder whether it is possible for such a parameter to be marked as LOC_COMPUTED or LOC_OPTIMIZED_OUT by var_decode_location. If so then changing the class to LOC_REF_ARG seems incorrect. Tom