From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30572 invoked by alias); 13 Oct 2010 18:44:21 -0000 Received: (qmail 30562 invoked by uid 22791); 13 Oct 2010 18:44:20 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Oct 2010 18:44:14 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9DIiAnX022618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Oct 2010 14:44:10 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id o9DIiAoL002116; Wed, 13 Oct 2010 14:44:10 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o9DIi9HK030344; Wed, 13 Oct 2010 14:44:09 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 3BC8F3791BC; Wed, 13 Oct 2010 12:44:09 -0600 (MDT) From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Subject: Re: [patch] fix exp/12117 References: <20101013175308.17B772461AE@ruffy.mtv.corp.google.com> Date: Wed, 13 Oct 2010 18:44:00 -0000 In-Reply-To: <20101013175308.17B772461AE@ruffy.mtv.corp.google.com> (Doug Evans's message of "Wed, 13 Oct 2010 10:53:08 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00229.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> This patch fixes pr exp/12117. Doug> http://sourceware.org/bugzilla/show_bug.cgi?id=12117 Doug> I will check this in in two days if there are no objections. It looks reasonable to me. Not an objection, but it seems odd that check_typedef can strip qualifiers from a type. It looks like it tries to do the right thing in some cases, but not all. Couldn't it just call make_qualified_type at the right point? Or unconditionally use that instead of checking TYPE_OBJFILE? Tom